fix cert-manager injection target #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehipwell
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks for the PR @PaulFarver, I think this is the fix for #1046 that I couldn't replicate. Have you tested the updated behaviour? Could you also please add an entry to the CHANGELOG under [UNRELEASED]?
|
Right... I tested it, but now I get the following 😅 So I'll change it to target the certificate resource with the other annotation |
PaulFarver
changed the title
|
Now it's tested and working :) |
Co-authored-by: Steve Hipwell <[email protected]>
|
@stevehipwell When do you usually release? |
|
Ahh... I see it now. I've created a PR for it at #1111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stevehipwell thanks for maintaining this chart 🎉
When running with
.Values.admissionController.certManager.enabledwe get the following error in our cert-manager-cainjector:Taking a look at the templates, it looks like the annotation expects a reference to a certificate, but gets a reference to a secret. We can fix that with the following, based on the documentation here: https://cert-manager.io/docs/concepts/ca-injector/#injecting-ca-data-from-a-secret-resource